On Tue, Dec 04, 2018 at 06:27:50PM +0000, Mark Bloch wrote:
>
>
> On 12/4/18 10:13 AM, Jason Gunthorpe wrote:
> > On Tue, Dec 04, 2018 at 03:32:44PM +0200, Leon Romanovsky wrote:
> >> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >>
> >> IB representors don't support creation of flows, there is no need to
> >> check rest of the parameters and return to the user an error anyway.
> >> Move representors check earlier in the flow and return proper error
> >> code in such case.
> >>
> >> Fixes: 322694412400 ("IB/mlx5: Introduce driver create and destroy flow methods")
> >> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >> ---
> >> drivers/infiniband/hw/mlx5/flow.c | 5 +++--
> >> 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > This should be handled by disabling the method, not returning
> > EOPNOTSUPP by hand, copy how it was done for devx in for-next
>
> Also disable the MATCHER creation method as well, if we can't create a flow
> no need for a matcher.
Thanks, I'll take a look.
>
> >
> > Jason
> >
>
> Mark
Attachment:
signature.asc
Description: PGP signature
