Re: [PATCH rdma-next] RDMA/mlx5: Fail early if user tries to create flows on IB representors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 04, 2018 at 03:32:44PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> 
> IB representors don't support creation of flows, there is no need to
> check rest of the parameters and return to the user an error anyway.
> Move representors check earlier in the flow and return proper error
> code in such case.
> 
> Fixes: 322694412400 ("IB/mlx5: Introduce driver create and destroy flow methods")
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/hw/mlx5/flow.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

This should be handled by disabling the method, not returning
EOPNOTSUPP by hand, copy how it was done for devx in for-next

Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux