Re: [PATCH rdma-rc] IB/mlx5: Fix XRC QP support after introducing extended atomic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 21, 2018 at 01:48:39PM +0200, Leon Romanovsky wrote:
> From: Yonatan Cohen <yonatanc@xxxxxxxxxxxx>
> 
> Extended atomics is supported with RC and XRC QP types,
> but commit citied in Fixes line added unneeded check
> to to_mlx5_access_flags. It broke XRC QP.
> 
> The following ib_atomic_bw invocation over XRC reproduces the issue:
>    ib_atomic_bw -d mlx5_1 --connection=XRC --atomic_type=FETCH_AND_ADD
> 
> It is safe to remove such check because QP type was already
> checked in ib_modify_qp_is_ok(), which is previously called
> from mlx5_ib_modify_qp.
> 
> Fixes: a60109dc9a95 ("IB/mlx5: Add support for extended atomic operations")
> Signed-off-by: Yonatan Cohen <yonatanc@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/hw/mlx5/qp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-rc, thanks

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux