Re: [PATCH rdma-core 9/9] rpm: Include static libraries in the build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-10-25 12:51 PM, Nicolas Morey-Chaisemartin wrote:


On 10/25/18 6:47 PM, Nicolas Morey-Chaisemartin wrote:

On 10/25/18 6:42 PM, Jarod Wilson wrote:

Something like this:

diff --git a/redhat/rdma-core.spec b/redhat/rdma-core.spec
index c281c5fa..19154ff5 100644
--- a/redhat/rdma-core.spec
+++ b/redhat/rdma-core.spec
@@ -11,6 +11,8 @@ License: GPLv2 or BSD
  Url: https://github.com/linux-rdma/rdma-core
  Source: rdma-core-%{version}.tgz

+%define with_static %{?_with_static: 1} %{?!_with_static: 0}
+
You could use:
%bcond_with static_libs
The code is simpler but deceiving as this means that "without" is the default.
...
>> Was looking into that and for some weird reason it fails on centos7:
...
> Scratch that. It works your way. Something does not like bcond on centos though

Yeah, I never liked the unintuitive appearance of bcond, and had vague recollections of it not being properly supported in older versions of rpm.

--
Jarod Wilson
jarod@xxxxxxxxxx



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux