On Wed, 2018-10-24 at 12:43 +0200, Nicolas Morey-Chaisemartin wrote:
>
> On 10/23/18 10:57 PM, Jason Gunthorpe wrote:
> > From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> >
> > Now that we can produce them properly, add them.
> >
> > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> > ---
> >
> > --- a/suse/rdma-core.spec
> > +++ b/suse/rdma-core.spec
> > @@ -144,6 +144,12 @@ Obsoletes: librdmacm-devel < %{version}-%{release}
> > Provides: ibacm-devel = %{version}-%{release}
> > Obsoletes: ibacm-devel < %{version}-%{release}
> >
> > +# Since our pkg-config files include private references to these packages they
> > +# need to have their .pc files installed too, even for dynamic linking, or
> > +# pkg-config breaks.
> > +BuildRequires: pkgconfig(libnl-3.0)
> > +BuildRequires: pkgconfig(libnl-route-3.0)
> > +
> > %description devel
> > RDMA core development libraries and headers.
> >
> > @@ -348,6 +354,7 @@ on those changes.
> > -DCMAKE_INSTALL_RUNDIR:PATH=%{_rundir} \
> > -DCMAKE_INSTALL_DOCDIR:PATH=%{_docdir}/%{name}-%{version} \
> > -DCMAKE_INSTALL_UDEV_RULESDIR:PATH=%{_udevrulesdir} \
> > + -DENABLE_STATIC=1 \
> > %{EXTRA_CMAKE_FLAGS}
> > %make_jobs
> >
> > @@ -526,6 +533,7 @@ rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
> > %dir %{_includedir}/rdma
> > %{_includedir}/infiniband/*
> > %{_includedir}/rdma/*
> > +%{_libdir}/lib*.a
> > %{_libdir}/lib*.so
> > %{_libdir}/pkgconfig/*.pc
> > %{_mandir}/man3/ibv_*
>
> SUSE packaging policy does not allow for static libraries (apart from a few rare exceptions).
> Thus, they shouldn't enable them by default. I'm not against adding a RPM option to enable it if needed.
Red Hat/Fedora have the same policy BTW. As far as Red Hat is
concerned, it's all about making sure that security updates to libraries
actually make it into use and insecure, broken libraries don't stay
hanging around because they are statically linked into something.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Attachment:
signature.asc
Description: This is a digitally signed message part
