On Wed, Oct 24, 2018 at 12:43:52PM +0200, Nicolas Morey-Chaisemartin wrote:
>
>
> On 10/23/18 10:57 PM, Jason Gunthorpe wrote:
> > From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> >
> > Now that we can produce them properly, add them.
> >
> > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> >
> > +++ b/suse/rdma-core.spec
> > @@ -144,6 +144,12 @@ Obsoletes: librdmacm-devel < %{version}-%{release}
> > Provides: ibacm-devel = %{version}-%{release}
> > Obsoletes: ibacm-devel < %{version}-%{release}
> >
> > +# Since our pkg-config files include private references to these packages they
> > +# need to have their .pc files installed too, even for dynamic linking, or
> > +# pkg-config breaks.
> > +BuildRequires: pkgconfig(libnl-3.0)
> > +BuildRequires: pkgconfig(libnl-route-3.0)
> > +
> > %description devel
> > RDMA core development libraries and headers.
> >
> > @@ -348,6 +354,7 @@ on those changes.
> > -DCMAKE_INSTALL_RUNDIR:PATH=%{_rundir} \
> > -DCMAKE_INSTALL_DOCDIR:PATH=%{_docdir}/%{name}-%{version} \
> > -DCMAKE_INSTALL_UDEV_RULESDIR:PATH=%{_udevrulesdir} \
> > + -DENABLE_STATIC=1 \
> > %{EXTRA_CMAKE_FLAGS}
> > %make_jobs
> >
> > @@ -526,6 +533,7 @@ rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
> > %dir %{_includedir}/rdma
> > %{_includedir}/infiniband/*
> > %{_includedir}/rdma/*
> > +%{_libdir}/lib*.a
> > %{_libdir}/lib*.so
> > %{_libdir}/pkgconfig/*.pc
> > %{_mandir}/man3/ibv_*
>
> SUSE packaging policy does not allow for static libraries (apart
> from a few rare exceptions). Thus, they shouldn't enable them by
> default. I'm not against adding a RPM option to enable it if needed.
Sure, I'll drop the patch to the suse/rdma-core.spec from this series.
Thanks,
Jason
