On 10/18/18 5:51 AM, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > Enrich rdmatool with an option to rename IB devices, > the command interface follows Iproute2 convention: > "rdma dev set [OLD-DEVNAME] name NEW-DEVNAME" > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > --- > rdma/dev.c | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/rdma/dev.c b/rdma/dev.c > index e2eafe47..760b7fb3 100644 > --- a/rdma/dev.c > +++ b/rdma/dev.c > @@ -14,6 +14,7 @@ > static int dev_help(struct rd *rd) > { > pr_out("Usage: %s dev show [DEV]\n", rd->filename); > + pr_out(" %s dev set [DEV] name DEVNAME\n", rd->filename); > return 0; > } > > @@ -240,17 +241,51 @@ static int dev_one_show(struct rd *rd) > return rd_exec_cmd(rd, cmds, "parameter"); > } > > +static int dev_set_name(struct rd *rd) > +{ > + uint32_t seq; > + > + if (rd_no_arg(rd)) { > + pr_err("Please provide device new name.\n"); > + return -EINVAL; > + } This is redundant with rd_exec_require_dev which is the required path to get to this point.