Re: [PATCH v2 4/4] IB/{hw,sw}: use rdma_is_user_pd instead of pd uobject pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shamir,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rdma/for-next]
[also build test ERROR on next-20181012]
[cannot apply to v4.19-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Shamir-Rabinovitch/RDMA-restrack-resource-tracker-should-not-use-uobject-pointers/20181015-015654
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function 'hns_roce_v2_destroy_qp':
>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c:4007:26: error: passing argument 1 of 'rdma_is_user_pd' from incompatible pointer type [-Werror=incompatible-pointer-types]
             rdma_is_user_pd(&ibqp->pd));
                             ^
   In file included from include/rdma/ib_addr.h:47:0,
                    from drivers/infiniband/hw/hns/hns_roce_hw_v2.c:39:
   include/rdma/ib_verbs.h:1553:20: note: expected 'struct ib_pd *' but argument is of type 'struct ib_pd **'
    static inline bool rdma_is_user_pd(struct ib_pd *pd)
                       ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/rdma_is_user_pd +4007 drivers/infiniband/hw/hns/hns_roce_hw_v2.c

  3999	
  4000	static int hns_roce_v2_destroy_qp(struct ib_qp *ibqp)
  4001	{
  4002		struct hns_roce_dev *hr_dev = to_hr_dev(ibqp->device);
  4003		struct hns_roce_qp *hr_qp = to_hr_qp(ibqp);
  4004		int ret;
  4005	
  4006		ret = hns_roce_v2_destroy_qp_common(hr_dev, hr_qp,
> 4007						    rdma_is_user_pd(&ibqp->pd));
  4008		if (ret) {
  4009			dev_err(hr_dev->dev, "Destroy qp failed(%d)\n", ret);
  4010			return ret;
  4011		}
  4012	
  4013		if (hr_qp->ibqp.qp_type == IB_QPT_GSI)
  4014			kfree(hr_to_hr_sqp(hr_qp));
  4015		else
  4016			kfree(hr_qp);
  4017	
  4018		return 0;
  4019	}
  4020	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux