Re: [PATCH v2 3/7] IB/verbs: dealloc_pd verb need ib_udata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shamir,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rdma/for-next]
[also build test ERROR on v4.19-rc7 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Shamir-Rabinovitch/convey-ib_ucontext-via-ib_udata/20181015-013324
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: x86_64-randconfig-x000-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bug.h:83:0,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:15,
                    from drivers/infiniband/core/verbs.c:43:
   drivers/infiniband/core/verbs.c: In function 'ib_dealloc_pd':
>> drivers/infiniband/core/verbs.c:340:10: error: implicit declaration of function 'rdma_is_user_pd'; did you mean 'rdma_is_zero_gid'? [-Werror=implicit-function-declaration]
     WARN_ON(rdma_is_user_pd(pd));
             ^
   include/asm-generic/bug.h:122:25: note: in definition of macro 'WARN_ON'
     int __ret_warn_on = !!(condition);    \
                            ^~~~~~~~~
   cc1: some warnings being treated as errors

vim +340 drivers/infiniband/core/verbs.c

   327	
   328	/**
   329	 * ib_dealloc_pd - Deallocates a protection domain.
   330	 * @pd: The protection domain to deallocate.
   331	 *
   332	 * It is an error to call this function while any resources in the pd still
   333	 * exist.  The caller is responsible to synchronously destroy them and
   334	 * guarantee no new allocations will happen.
   335	 *
   336	 * NOTE: Never call this function from uverbs!
   337	 */
   338	void ib_dealloc_pd(struct ib_pd *pd)
   339	{
 > 340		WARN_ON(rdma_is_user_pd(pd));
   341		ib_dealloc_pd_user(pd, NULL);
   342	}
   343	EXPORT_SYMBOL(ib_dealloc_pd);
   344	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux