On Sun, Oct 07, 2018 at 10:23:06AM +0300, Shamir Rabinovitch wrote: > uobject pointers should not be used in ib core layer. they only > belong to ib uverbs. as result, resource tracker should not use > them as well. > > Signed-off-by: Shamir Rabinovitch <shamir.rabinovitch@xxxxxxxxxx> > drivers/infiniband/core/core_priv.h | 1 + > drivers/infiniband/core/cq.c | 1 + > drivers/infiniband/core/restrack.c | 16 +--------------- > drivers/infiniband/core/uverbs_cmd.c | 3 +++ > drivers/infiniband/core/uverbs_std_types_cq.c | 1 + > drivers/infiniband/core/verbs.c | 3 +++ > include/rdma/restrack.h | 4 ++++ > 7 files changed, 14 insertions(+), 15 deletions(-) > > diff --git a/drivers/infiniband/core/core_priv.h b/drivers/infiniband/core/core_priv.h > index d7399d5b1cb6..4b98a967b821 100644 > +++ b/drivers/infiniband/core/core_priv.h > @@ -324,6 +324,7 @@ static inline struct ib_qp *_ib_create_qp(struct ib_device *dev, > */ > if (attr->qp_type < IB_QPT_XRC_INI) { > qp->res.type = RDMA_RESTRACK_QP; > + qp->res.user = !!uobj; No need for !! when assigning to bool Jason