On Sun, Oct 07, 2018 at 12:03:36PM +0300, Leon Romanovsky wrote: > From: Yonatan Cohen <yonatanc@xxxxxxxxxxxx> > > Flags sent down from user might not be supported by > running driver. > This might lead to unwanted bugs. > To solve this, added macro to test for unsupported flags. > > Signed-off-by: Yonatan Cohen <yonatanc@xxxxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > drivers/infiniband/hw/mlx5/qp.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c > index bae48bdf281c..17c4b6641933 100644 > +++ b/drivers/infiniband/hw/mlx5/qp.c > @@ -1728,6 +1728,15 @@ static void configure_requester_scat_cqe(struct mlx5_ib_dev *dev, > MLX5_SET(qpc, qpc, cs_req, MLX5_REQ_SCAT_DATA32_CQE); > } > > +#define MLX5_QP_CREATE_FLAGS_NOT_SUPPORTED(flags) \ > + ((flags) & ~( \ This needs a cast, it would be better to add something like the check comp mask function in rdma-core than this goofy macro thing. Jason
