On Thu, Sep 13, 2018 at 05:55:44AM -0600, Håkon Bugge wrote: > Hi Faisal, > > > In commit f27b4746f378 ("i40iw: add connection management code") you have in i40iw_add_mqh_6(): > > rtnl_lock(); > for_each_netdev_rcu(...) { > [] > } > rtnl_unlock(); > > Shouldn't this read: > rtnl_lock(); > for_each_netdev(...) { > [] > } > rtnl_unlock(); > Yes.