mutex and rcu list traversal idiosyncrasy

[Håkon Bugge <haakon.bugge@xxxxxxxxxx>]

Hi Faisal,


In commit f27b4746f378 ("i40iw: add connection management code") you have in i40iw_add_mqh_6():

rtnl_lock();
for_each_netdev_rcu(...) {
	[]
}
rtnl_unlock();

Shouldn't this read:

rtnl_lock();
for_each_netdev(...) {
	[]
}
rtnl_unlock();

or

rcu_read_lock();
for_each_netdev_rcu(...) {
	[]
}
rcu_read_unlock();


?



Thx, Håkon