Thanks Bart, I hadn't properly subscribed to the mailing list earlier and missed Jason's patch. I went back and re-read it. I will submit another patch to the kernel side applying his suggestion. Seth -----Original Message----- From: Bart Van Assche +AFs-mailto:Bart.VanAssche+AEA-wdc.com+AF0- Sent: Tuesday, August 14, 2018 8:10 AM To: Howell, Seth +ADs- linux-rdma+AEA-vger.kernel.org Cc: Walker, Benjamin Subject: Re: +AFs-PATCH+AF0- RXE: Add translation for kernel space enums On Tue, 2018-08-14 at 15:04 +-0000, Howell, Seth wrote: +AD4- Is there a specific reason duplicating the user-space enum in the +AD4- kernel would be inherently better than implementing it here? Not really. I'm fine with Jason's proposal, namely to move the IB+AF8-WR+AF8AKg- constants into a header file under include/uapi/. That approach has the advantage that there won't be any duplication of constant definitions. Bart.