Re: [PATCH v3] IB/uverbs: Add UVERBS_ATTR_FLAGS_IN to the specs language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 14, 2018 at 04:23:21PM +0300, Yishai Hadas wrote:
> > > If you are doing this, can't the top 4 bytes have garbage from the stack?
> > 
> > Indeed, this was missed during testing apparently. It should read
> > 
> > -               memcpy(&flags, &attr->ptr_attr.data, 4);
> > +               flags = *(u32 *)&attr->ptr_attr.data;
> > 
> 
> Hi Jason,
> 
> It looks that 'for-next' doesn't include yet this fix, let's please not miss
> it. I just hit this problem in some test which uses this code as part of
> DEVX.

It has been in the WIP branch for a bit, it is pushed to official
for-next now

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux