> > static uint hfi1_hdrq_entsize = 32; > > -module_param_named(hdrq_entsize, hfi1_hdrq_entsize, uint, S_IRUGO); > > -MODULE_PARM_DESC(hdrq_entsize, "Size of header queue entries: 2 - > 8B, 16 - 64B (default), 32 - 128B"); > > +module_param_named(hdrq_entsize, hfi1_hdrq_entsize, uint, 0444); > > +MODULE_PARM_DESC(hdrq_entsize, "Size of header queue entries: 2 - > 8B, 16 - 64B, 32 - 128B (default)"); > > How is this hunk related to this patch? > As part of the fix, I noticed the module parameter comment was wrong. The default is actually 128B not 64B. To fix that and the resulting warning on S_IRUGO added this. Technically, the fix is cleanup that could be separate from the code that micro optimizes the hot path access. Do you want an additional patch? Mike -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
