On Wed, May 23, 2018 at 03:00:26PM -0600, Jason Gunthorpe wrote: > To avoid a gcc 8 warning: > > ../srp_daemon/srp_ib_types.h:215:3: warning: alignment 1 of ‘struct _ntc_64_67’ is less than 4 [-Wpacked-not-aligned] > } PACK_SUFFIX ntc_64_67; > ^ > ../srp_daemon/srp_ib_types.h:214:19: warning: ‘gid’ offset 6 in ‘struct _ntc_64_67’ isn’t aligned to 4 [-Wpacked-not-aligned] > union umad_gid gid; // the Node or Multicast Group that came in/out > > This requires making the sub structures in the union aligned to a natural > point, by absorbing the common member in the union sub structures. Then > the compiler can see the alignment of everything is natural and packed is > also no longer required at all. > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > --- > srp_daemon/srp_daemon.c | 6 +++++- > srp_daemon/srp_handle_traps.c | 8 ++++---- > srp_daemon/srp_ib_types.h | 34 +++++++++++++++++++--------------- > 3 files changed, 28 insertions(+), 20 deletions(-) > > Leon this replaces your 'cmake; Mask packed-not-aligned GCC warnings' > patch in your FC28 series. https://github.com/linux-rdma/rdma-core/pull/335 Thanks
Attachment:
signature.asc
Description: PGP signature
