On Wed, May 23, 2018 at 09:42:56AM -0600, Jason Gunthorpe wrote:
> On Wed, May 23, 2018 at 11:16:55AM +0300, Leon Romanovsky wrote:
> > On Tue, May 22, 2018 at 02:48:20PM -0600, Jason Gunthorpe wrote:
> > > On Tue, May 15, 2018 at 05:09:45PM +0300, Leon Romanovsky wrote:
> > > > From: Raed Salem <raeds@xxxxxxxxxxxx>
> > > >
> > > > A counters object could be attached to flow on creation
> > > > by providing the counter specification action.
> > > >
> > > > General counters description which count packets and bytes are
> > > > introduced, downstream patches from this series will use them
> > > > as part of flow counters binding.
> > > >
> > > > In addition, increase number of flow specifications supported
> > > > layers to 10 upon adding count specification and for the
> > > > previously added drop specification.
> > > >
> > > > Reviewed-by: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> > > > Signed-off-by: Raed Salem <raeds@xxxxxxxxxxxx>
> > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > > include/rdma/ib_verbs.h | 15 ++++++++++++++-
> > > > 1 file changed, 14 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> > > > index 869e3cdee7dc..cb00795a86de 100644
> > > > +++ b/include/rdma/ib_verbs.h
> > > > @@ -1861,9 +1861,10 @@ enum ib_flow_spec_type {
> > > > IB_FLOW_SPEC_ACTION_TAG = 0x1000,
> > > > IB_FLOW_SPEC_ACTION_DROP = 0x1001,
> > > > IB_FLOW_SPEC_ACTION_HANDLE = 0x1002,
> > > > + IB_FLOW_SPEC_ACTION_COUNT = 0x1003,
> > > > };
> > >
> > > This entire enum is uapi and doesn't belong here.. Please send a
> > > follow up patch to move it
> >
> > I'll take a look on it after we will finish GRH required patches and
> > will create new dedicated header file. It is not clear to which file
> > this enum should be moved now. It won't be in next v1.
>
> It must go to
>
> include/uapi/rdma/ib_user_ioctl_verbs.h
>
> This is the header that is designed to be co-included with userspace
> vervb.h (eg through verbs_api.h), which will ultimately allow the
> duplication of these constants in verbs.h to be unified.
>
> And since this patch is full of putting uapi constants in the wrong
> header, it may as well get fixed all at once.
ok, I'll take a close look after this series.
Thanks
>
> Jason
Attachment:
signature.asc
Description: PGP signature
