On Wed, 2018-05-16 at 12:14 -0600, Jason Gunthorpe wrote:
> On Wed, May 16, 2018 at 04:31:10PM +0300, Yishai Hadas wrote:
> > From: Ariel Levkovich <lariel@xxxxxxxxxxxx>
> >
> > This patch exposes the mlx5 device's capability to offload MPLS based
> > tunnel protocols via DV API.
> > The possible protocols are:
> > - Control word + MPLS over GRE.
> > - Control word + MPLS over UDP.
> >
> > Signed-off-by: Ariel Levkovich <lariel@xxxxxxxxxxxx>
> > Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> > providers/mlx5/mlx5dv.h | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/providers/mlx5/mlx5dv.h b/providers/mlx5/mlx5dv.h
> > index 2c31988..41493a6 100644
> > +++ b/providers/mlx5/mlx5dv.h
> > @@ -92,9 +92,11 @@ struct mlx5dv_striding_rq_caps {
> > };
> >
> > enum mlx5dv_tunnel_offloads {
> > - MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_VXLAN = 1 << 0,
> > - MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GRE = 1 << 1,
> > - MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GENEVE = 1 << 2,
> > + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_VXLAN = 1 << 0,
> > + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GRE = 1 << 1,
> > + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_GENEVE = 1 << 2,
> > + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_CW_MPLS_OVER_GRE = 1 << 3,
> > + MLX5DV_RAW_PACKET_CAP_TUNNELED_OFFLOAD_CW_MPLS_OVER_UDP = 1 << 4,
> > };
>
> Bleck, I dislike this mindless whitespace change and this is part of
> why I so dislike the 'column' alignment so much code is fond of...
So, this whitespace churn makes patches harder to read, but I would
argue the columnization makes the code itself easier to read. So I can
see both sides of it.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
