> From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > Sent: Tuesday, May 15, 2018 12:09 PM > To: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > Cc: Kalderon, Michal <Michal.Kalderon@xxxxxxxxxx>; > dledford@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Bason, Yuval > <Yuval.Bason@xxxxxxxxxx>; Elior, Ariel <Ariel.Elior@xxxxxxxxxx> > Subject: Re: [PATCH for-rc] RDMA/qedr: Fix doorbell bar mapping for dpi > 1 > > On Mon, May 14, 2018 at 03:14:11PM -0600, Jason Gunthorpe wrote: > > On Mon, May 14, 2018 at 08:01:32PM +0000, Kalderon, Michal wrote: > > > From: linux-rdma-owner@xxxxxxxxxxxxxxx > > > <linux-rdma-owner@xxxxxxxxxxxxxxx> on behalf of Jason Gunthorpe > > > <jgg@xxxxxxxxxxxx> > > > > > > > > > > 1 file changed, 28 insertions(+), 31 deletions(-) > > > > > > > > > > > > Please don't leak kernel pointers [1], and use %pK instead of %x [2]. > > > > > > > > > > > > [1] https://lwn.net/Articles/735589/ [2] > > > > > > Documentation/core-api/printk-formats.rst > > > > > > > > > > > > Thanks > > > > > It's important for debugging to see the actual doorbell address. > > > (and it seems %pK gives a hashed value and not actual value like > > > %lx) I can send a v2 to change the vma addresses to be printed with > > > %pk although they are printed in other driver (mlx) with %lx as > > > well. > > > > I'm sure Leon will fix mlx drivers if he is made aware of where they > > are doing this.. > > Or patch which removes them. https://elixir.bootlin.com/linux/v4.17-rc5/source/drivers/infiniband/hw/mlx5/main.c#L2061 https://elixir.bootlin.com/linux/v4.17-rc5/source/drivers/infiniband/hw/mlx5/main.c#L2166 > > Thanks > > > > > Jason > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More > majordomo > > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
