On Mon, May 14, 2018 at 07:31:22AM +0000, Kalderon, Michal wrote: > From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > Sent: Monday, May 14, 2018 9:37 AM > > > > On Sun, May 13, 2018 at 09:07:07PM +0300, Michal Kalderon wrote: > > > Each user_context receives a separate dpi value and thus a different > > > address on the doorbell bar. The qedr_mmap function needs to validate > > > the address and map the doorbell bar accordingly. > > > The current implementation always checked against dpi=0 doorbell range > > > leading to a wrong mapping for doorbell bar. (It entered an else case > > > that mapped the address differently). qedr_mmap should only be used > > > for doorbells, so the else was actually wrong in the first place. > > > This only has an affect on arm architecture and not an issue on a > > > x86 based architecture. > > > This lead to doorbells not occurring on arm based systems and left > > > applications that use more than one dpi (or several applications run > > > simultaneously ) to hang. > > > > > > Fixes: ac1b36e55a51 ("qedr: Add support for user context verbs") > > > Signed-off-by: Ariel Elior <Ariel.Elior@xxxxxxxxxx> > > > Signed-off-by: Michal Kalderon <Michal.Kalderon@xxxxxxxxxx> > > > drivers/infiniband/hw/qedr/verbs.c | 59 > > > ++++++++++++++++++-------------------- > > > 1 file changed, 28 insertions(+), 31 deletions(-) > > > > Please don't leak kernel pointers [1], and use %pK instead of %x [2]. > > > > [1] https://lwn.net/Articles/735589/ > > [2] Documentation/core-api/printk-formats.rst > > > > Thanks > Thanks for pointing these out. I was not familiar with this > convention. However, the addresses Which are printed below are the > physical doorbell addresses which don't I think PCI physical addresses are expected to be protected as well. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
