On Sun, May 06, 2018 at 10:17:43AM +0300, Or Gerlitz wrote:
> On Thu, May 3, 2018 at 4:37 PM, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> > From: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> >
> > This patch updates the mlx5_ifc structures with the following:
> > - Expose general command header in/out format.
> > - Expose user context format.
> > - Expose umem format.
> >
> > Downstream patches from this series will use this stuff.
> >
> > Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > ---
> > include/linux/mlx5/mlx5_ifc.h | 52 +++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 52 insertions(+)
> >
> > diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
> > index 18e72c79015c..8c0f4e19d4c3 100644
> > --- a/include/linux/mlx5/mlx5_ifc.h
> > +++ b/include/linux/mlx5/mlx5_ifc.h
> > @@ -9076,4 +9076,56 @@ struct mlx5_ifc_dealloc_memic_out_bits {
> > u8 reserved_at_40[0x40];
> > };
> >
> > +struct mlx5_ifc_general_obj_in_cmd_hdr_bits {
> > + u8 opcode[0x10];
> > + u8 uid[0x10];
> > +
> > + u8 reserved_0[0x10];
>
> Hi Yishai, Leon,
>
> We have stopped using the reserved_N method 1-2 years ago
> after it was pointed to us by Linus T. we are buggish there.
>
> We have automated means to generate these structs with
> reserved_at_N method, just use them
Ohh, thank you, it is my shame that I missed it. We will fix it.
Thanks
Attachment:
signature.asc
Description: PGP signature
