Re: [PATCH rdma-next 12/21] IB/mlx5: Expose DEVX ifc structures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 3, 2018 at 4:37 PM, Leon Romanovsky <leon@xxxxxxxxxx> wrote:
> From: Yishai Hadas <yishaih@xxxxxxxxxxxx>
>
> This patch updates the mlx5_ifc structures with the following:
> - Expose general command header in/out format.
> - Expose user context format.
> - Expose umem format.
>
> Downstream patches from this series will use this stuff.
>
> Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
>  include/linux/mlx5/mlx5_ifc.h | 52 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
>
> diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
> index 18e72c79015c..8c0f4e19d4c3 100644
> --- a/include/linux/mlx5/mlx5_ifc.h
> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -9076,4 +9076,56 @@ struct mlx5_ifc_dealloc_memic_out_bits {
>         u8         reserved_at_40[0x40];
>  };
>
> +struct mlx5_ifc_general_obj_in_cmd_hdr_bits {
> +       u8         opcode[0x10];
> +       u8         uid[0x10];
> +
> +       u8         reserved_0[0x10];

Hi Yishai, Leon,

We have stopped using the reserved_N method 1-2 years ago
after it was pointed to us by Linus T. we are buggish there.

We have automated means to generate these structs with
reserved_at_N method, just use them


> +       u8         obj_type[0x10];
> +
> +       u8         obj_id[0x20];
> +
> +       u8         reserved_1[0x20];

fix

> +};
> +
> +struct mlx5_ifc_general_obj_out_cmd_hdr_bits {
> +       u8         status[0x8];
> +       u8         reserved_0[0x18];

fix

> +
> +       u8         syndrome[0x20];
> +
> +       u8         obj_id[0x20];
> +
> +       u8         reserved_1[0x20];

fix

> +};
> +
> +struct mlx5_ifc_umem_bits {
> +       u8         modify_field_select[0x40];
> +
> +       u8         reserved_0[0x5b];
> +       u8         log_page_size[0x5];
> +
> +       u8         page_offset[0x20];
> +
> +       u8         num_of_mtt[0x40];
> +
> +       struct mlx5_ifc_mtt_bits  mtt[0];
> +};
> +
> +struct mlx5_ifc_uctx_bits {
> +       u8         modify_field_select[0x40];
> +
> +       u8         reserved[0x1c0];

fix

> +};
> +
> +struct mlx5_ifc_create_umem_in_bits {
> +       struct mlx5_ifc_general_obj_in_cmd_hdr_bits   hdr;
> +       struct mlx5_ifc_umem_bits                     umem;
> +};
> +
> +struct mlx5_ifc_create_uctx_in_bits {
> +       struct mlx5_ifc_general_obj_in_cmd_hdr_bits   hdr;
> +       struct mlx5_ifc_uctx_bits                     uctx;
> +};
> +
>  #endif /* MLX5_IFC_H */
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux