Re: [PATCH rdma-rc] RDMA/cma: Zero out qp and ah attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 01, 2018 at 01:40:46PM -0600, Jason Gunthorpe wrote:
> On Tue, May 01, 2018 at 07:32:10PM +0000, Parav Pandit wrote:
>
> > Right.
> > Please go through commit log. It is in Leon's queue.
> > https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/commit/?h=rdma-next&id=8858e62f3ff9b6cd0242edeb89b47e61a2c24a5f
>
> Okay.

In offline discussion prior to submission, me and Parav decided that
current patch (zero out) is good enough for -rc, but removal is better
to be sent to -next.

>
> We should get rid of that BUG_ON in a preceeding patch in case Linus
> looks at the patches :(
>
> Leon, what do you think about just sending a patch to replace the
> BUG_ON's with WARN_ON ?

I'm not fan of such dumb replacement, hope that I'll catch some BUG_ONs
which for sure not possible and remove them.

>
> $ git grep BUG_ON drivers/infiniband/ | wc --l
> 136

You can immediately remove 33 occurrences by simply adding "-w" in git grep line :)

➜ git grep -w BUG_ON drivers/infiniband/ | wc -l
103

Thanks

>
> :(
>
> Jason
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux