> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Tuesday, May 01, 2018 2:41 PM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Doug Ledford <dledford@xxxxxxxxxx>; Leon Romanovsky > <leon@xxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>; Raju > Rangoju <rajur@xxxxxxxxxxx>; Leon Romanovsky <leonro@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-rc] RDMA/cma: Zero out qp and ah attribute > > On Tue, May 01, 2018 at 07:32:10PM +0000, Parav Pandit wrote: > > > Right. > > Please go through commit log. It is in Leon's queue. > > https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/co > > mmit/?h=rdma-next&id=8858e62f3ff9b6cd0242edeb89b47e61a2c24a5f > > Okay. > > We should get rid of that BUG_ON in a preceeding patch in case Linus looks at > the patches :( > Yes. The right fix is to move up the validation cma_modify_qp_rtr() like QP check and return error because cma_dev binding is done before that. > Leon, what do you think about just sending a patch to replace the BUG_ON's > with WARN_ON ? > > $ git grep BUG_ON drivers/infiniband/ | wc --l > 136 > > :( > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
