On Wed, Apr 25, 2018 at 06:34:12PM +0300, Leon Romanovsky wrote:
> On Wed, Apr 25, 2018 at 02:33:42PM +0300, Shamir Rabinovitch wrote:
> > Not sure if GCC 4.4.7 should be supported or not...
> >
> > I hit build issue originated from commit:
> > 2eb9bea IB/uverbs: Add flow_action create and destroy verbs
> >
> > The below sample code trigger the same issue seen with above
> > patch.
> >
> > ===============================
> >
> > include <stdio.h>
> >
> > struct a {
> > union {
> > struct {
> > int i;
> > } ptr;
> > };
> > };
> >
> > void main(void)
> > {
> > struct a my_a = { .ptr = { 1 } };
> > }
> >
> > ===============================
> >
> > gcc version 4.4.7 20120313 (Red Hat 4.4.7-18.0.7) (GCC)
> >
> > gcc test.c
> > test.c: In function ‘main’:
> > test.c:14: error: unknown field ‘ptr’ specified in initializer
> >
> > ===============================
> >
> > gcc version 4.8.5 20150623 (Red Hat 4.8.5-16.0.3) (GCC)
> >
> > PASS
> >
> > ===============================
>
> Doesn't this patch [1] fix the compilation issue?
> It was accepted by Jason, but he still didn't push it.
>
> [1] https://patchwork.kernel.org/patch/10331623/
>
> Thanks
>
>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks a lot Leon !
I confirmed that the above patch fix the issue I saw.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
