Re: [PATCH rdma-core] debian: Do not require valgrind on riscv64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 26, 2018 at 04:20:17PM +0200, Benjamin Drung wrote:
> Am Donnerstag, den 26.04.2018, 13:39 +0300 schrieb Leon Romanovsky:
> > On Fri, Apr 20, 2018 at 11:01:22AM +0200, Benjamin Drung wrote:
> > > valgrind is not available on the quite new riscv64 architecture and
> > > it
> > > is not likely to have valgrind soon. Therefore rdma-core shouldn't
> > > build-depend on it.
> > >
> > > Closes: #896150
> > > Thanks: Manuel A. Fernandez Montecelo <mafm@xxxxxxxxxx>
> > > Signed-off-by: Benjamin Drung <benjamin.drung@xxxxxxxxxxxxxxxx>
> > > ---
> > >  debian/control | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> > I wonder if the easy path is to write where valgrind works instead of
> > blacklisting everything.
>
> Whitelisting is an option too. We either have to maintain either list
> (either the archs which have valgrind or the archs that do not have
> it). Should I switch to whitelisting?

Completely upto you. IMHO, it is better to wait for next update of this
line and to switch at that point.

Thanks

>
> --
> Benjamin Drung
> System Developer
> Debian & Ubuntu Developer
>
> ProfitBricks GmbH
> Greifswalder Str. 207
> 10405 Berlin
>
> Email: benjamin.drung@xxxxxxxxxxxxxxxx
> URL: https://www.profitbricks.de
>
> Sitz der Gesellschaft: Berlin
> Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
> Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens


Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux