On Thu, 2018-04-19 at 12:49 -0600, Jason Gunthorpe wrote:
> On Thu, Apr 19, 2018 at 02:23:25PM -0400, Doug Ledford wrote:
> > On Thu, 2018-04-05 at 18:55 +0300, Leon Romanovsky wrote:
> > > On Wed, Apr 04, 2018 at 09:00:01PM -0600, Jason Gunthorpe wrote:
> > > > This is done by auditing all callers of ucma_get_ctx and switching the
> > > > ones that unconditionally touch ->device to ucma_get_ctx_dev. This covers
> > > > a little less than half of the call sites.
> > > >
> > > > The 11 remaining call sites to ucma_get_ctx() were manually audited.
> > > >
> > > > It looks like none of these cases cause bugs due to the FSM system
> > > > inside the CMA, but documenting the requirement and the result of this
> > > > audit is still productive.
> > > >
> > > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> > > > drivers/infiniband/core/ucma.c | 36 ++++++++++++++++++++++++------------
> > > > 1 file changed, 24 insertions(+), 12 deletions(-)
> > > >
> > > > v3:
> > > > - Reorder the function after put_ctx so it compiles warning free
> > > > I really shouldn't rush so much :(
> > > >
> > >
> > > Thanks,
> > > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >
> > Thanks, applied. This seemed important enough to warrant early -rc, so
> > I put it there instead of for-next.
>
> You may want to change the last paragraph there as it apparently does
> fix syzkaller bugs :(
I can still do that, I haven't pushed my tree for today as of yet. I'll
fix it up before I push.
> If I'd known that it would have gone weeks ago.
I wondered about that ;-)
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
