Re: [PATCH v3] RDMA/ucma: Check for a cm_id->device in all user calls that need it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-04-05 at 18:55 +0300, Leon Romanovsky wrote:
> On Wed, Apr 04, 2018 at 09:00:01PM -0600, Jason Gunthorpe wrote:
> > This is done by auditing all callers of ucma_get_ctx and switching the
> > ones that unconditionally touch ->device to ucma_get_ctx_dev. This covers
> > a little less than  half of the call sites.
> > 
> > The 11 remaining call sites to ucma_get_ctx() were manually audited.
> > 
> > It looks like none of these cases cause bugs due to the FSM system
> > inside the CMA, but documenting the requirement and the result of this
> > audit is still productive.
> > 
> > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> > ---
> >  drivers/infiniband/core/ucma.c | 36 ++++++++++++++++++++++++------------
> >  1 file changed, 24 insertions(+), 12 deletions(-)
> > 
> > v3:
> > - Reorder the function after put_ctx so it compiles warning free
> >   I really shouldn't rush so much :(
> > 
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

Thanks, applied.  This seemed important enough to warrant early -rc, so
I put it there instead of for-next.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux