Hi Sagi, We are running nvmf link-test (toggling the link with some delay) to ensure that the connections are restored and I/O resumes on link-up. This test used to work until the commit e818a5b. But with this commit included, we see I/O errors as the link goes down, also when the link comes up, the nvmf disks are remounted as read-only and doesn't allow I/O run. As per commit message, this seems to be the expected behaviour. Could you please confirm if what we are seeing is expected? Same behaviour is seen with other vendors too. Here is the commit msg: *commit e818a5b487fea20494b0e48548c1085634abdc0d Author: Sagi Grimberg <sagi@xxxxxxxxxxx> Date: Mon Jun 5 20:35:56 2017 +0300 nvme-rdma: fast fail incoming requests while we reconnect When we encounter an transport/controller errors, error recovery kicks in which performs: 1. stops io/admin queues 2. moves transport queues out of LIVE state 3. fast fail pending io 4. schedule periodic reconnects. But we also need to fast fail incoming IO taht enters after we already scheduled. Given that our queue is not LIVE anymore, simply restart the request queues to fail in .queue_rq I/O errors: [Tue Apr 3 19:14:55 2018] print_req_error: I/O error, dev nvme2n1, sector 1108136 [Tue Apr 3 19:14:55 2018] Aborting journal on device nvme2n1-8. [Tue Apr 3 19:14:55 2018] print_req_error: I/O error, dev nvme2n1, sector 1052688 [Tue Apr 3 19:14:55 2018] Buffer I/O error on dev nvme2n1, logical block 131586, lost sync page write [Tue Apr 3 19:14:55 2018] JBD2: Error -5 detected when updating journal superblock for nvme2n1-8. and IO fails to resume as the devices are remounted as read-only... Can not open temp file: iozone.tmp open: Read-only file system Thanks, Raju -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html