Re: [PATCH rdma-next v1 0/7] GID refactoring cont 3.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 01, 2018 at 03:08:17PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> 
> Changelog:
> v0->v1:
>  1. RoCE GID locking scheme is simplified where gid table update
>     routines always take mutex lock for all link layers and reader takes rw_lock.
>     GID table entry property is updated under write lock.
>  2. query_gid is made optional routine and core optionally invoke it, if
>     supported. Associated providers updated.
>  3. qedr driver is simplified to not implement add_gid, del_gid routines
>     This resulted in addition of one more patch.
>     3rd patch helps to reduce gid_ref_cnt patch series to shorter by another
>     19 lines.
> 
> Thanks,
>    Parav
> 
> Parav Pandit (7):
>   RDMA/core: Update query_gid documentation for HCA drivers
>   RDMA/providers: Simplify query_gid callback of RoCE providers
>   IB/core: Simplify ib_query_gid to always refer to cache
>   IB/core: Refactor GID modify code for RoCE
>   IB/providers: Avoid zero GID check for RoCE
>   IB/providers: Avoid null netdev check for RoCE
>   RDMA: Use ib_gid_attr during GID modification

I took this series into for-next, several of the commit messages were
re-worded and the rxe patch revised as discussed. Please check it.

However this patch:
   IB/core: Refactor GID modify code for RoCE

Is really doing too much at once. I *only* took it this time because I
already reviewed it extremely extensively and it is such a nice
cleanup. Plus it appeared to be a bit difficult to disentangle some of
the interlocking changes.

In future if you find yourself writing a list of bullets describing
what the patch does then please split it up

>  24 files changed, 397 insertions(+), 508 deletions(-)

Yay! Less code!

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux