On Wed, Apr 04, 2018 at 03:50:02AM +0000, Parav Pandit wrote: > > > > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > > Sent: Tuesday, April 03, 2018 10:32 PM > > To: Leon Romanovsky <leon@xxxxxxxxxx> > > Cc: Doug Ledford <dledford@xxxxxxxxxx>; Leon Romanovsky > > <leonro@xxxxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>; > > Mark Bloch <markb@xxxxxxxxxxxx>; Parav Pandit <parav@xxxxxxxxxxxx> > > Subject: Re: [PATCH rdma-next v1 2/7] RDMA/providers: Simplify query_gid > > callback of RoCE providers > > > > On Sun, Apr 01, 2018 at 03:08:19PM +0300, Leon Romanovsky wrote: > > > > > diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c > > > b/drivers/infiniband/sw/rxe/rxe_verbs.c > > > index 5ef8c3333e43..52ff30a58aa3 100644 > > > +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c > > > @@ -80,18 +80,7 @@ static int rxe_query_port(struct ib_device *dev, > > > static int rxe_query_gid(struct ib_device *device, > > > u8 port_num, int index, union ib_gid *gid) { > > > - int ret; > > > - > > > - if (index > RXE_PORT_GID_TBL_LEN) > > > - return -EINVAL; > > > - > > > - ret = ib_get_cached_gid(device, port_num, index, gid, NULL); > > > - if (ret == -EAGAIN) { > > > - memcpy(gid, &zgid, sizeof(*gid)); > > > - return 0; > > > - } > > > - > > > - return ret; > > > + return 0; > > > } > > > > This entire function should have been deleted in the next patch, right? > > > > I can fix it if yes. > > > Yes. That's correct. I've revised the patches then > rxe_add_gid() and rxe_del_gid() needs to follow same removal path. I missed out. Okay. Please send that as a followup patch like QEDR. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
