On Mon, Mar 26, 2018 at 12:13:53PM -0500, Steve Wise wrote: > > > On 3/26/2018 12:06 PM, Leon Romanovsky wrote: > > On Mon, Mar 26, 2018 at 10:24:25AM -0500, Steve Wise wrote: > >> > >> On 3/26/2018 10:08 AM, Leon Romanovsky wrote: > >>> On Mon, Mar 26, 2018 at 09:55:46AM -0500, Steve Wise wrote: > >>>> On 3/26/2018 9:44 AM, David Ahern wrote: > >>>>> On 3/26/18 8:30 AM, Steve Wise wrote: > >>>>>> On 3/26/2018 9:17 AM, David Ahern wrote: > >>>>>>> On 2/27/18 9:07 AM, Steve Wise wrote: > >>>>>>>> diff --git a/rdma/rdma.h b/rdma/rdma.h > >>>>>>>> index 5809f70..e55205b 100644 > >>>>>>>> --- a/rdma/rdma.h > >>>>>>>> +++ b/rdma/rdma.h > >>>>>>>> @@ -18,10 +18,12 @@ > >>>>>>>> #include <libmnl/libmnl.h> > >>>>>>>> #include <rdma/rdma_netlink.h> > >>>>>>>> #include <time.h> > >>>>>>>> +#include <net/if_arp.h> > >>>>>>>> > >>>>>>>> #include "list.h" > >>>>>>>> #include "utils.h" > >>>>>>>> #include "json_writer.h" > >>>>>>>> +#include <rdma/rdma_cma.h> > >>>>>>>> > >>>>>>> did you forget to add rdma_cma.h? I don't see that file in my repo. > >>>>>> It is provided by the rdma-core package, upon which rdma tool now > >>>>>> depends for the rdma_port_space enum. > >>>>>> > >>>>> You need to add a check for the package, and only build rdma if that > >>>>> package is installed. See check_mnl in configure for an example. > >>>> Ok, that makes sense. > >>> IMHO, better solution will be to copy those files to iproute2. > >> Hey Leon, > >> > >> Why is it better in your opinion? My gut tells me adding rdma_cma.h to > >> iproute2 means more uabi type syncing. > > Making rdmatool be dependant on rdma-core will require that distributions > > will update their specs to install rdma-core as a dependency for every > > iprotue2 install. > > > > The rdma-core dependency makes sense for RDMA users, but doesn't for most of > > the iproute2 users. > > I'm fuzzy on the details of distro packaging, but David's suggestion is > that rdmatool wouldn't get built if rdma-core isn't present. But > everything else would. Just like it does not get built if libmnl is not > installed. For pre-built rpms, the rdma-core would have to be present. > > I'm ok pulling it in, I'm just trying to understand. :) > Distros supply pre-built packages, for example Fedora's RPM: https://rpmfind.net/linux/RPM/fedora/27/x86_64/i/iproute-4.12.0-3.fc27.x86_64.html It requires that libmnl will be installed. Once rdmatool will need rdma-core, it will pulled in too. BTW, don't forget to change header's guards (ifdef/defne ..), see rdma_netlink.h as an example. > Steve. > > > >
Attachment:
signature.asc
Description: PGP signature
