On 3/26/2018 10:08 AM, Leon Romanovsky wrote: > On Mon, Mar 26, 2018 at 09:55:46AM -0500, Steve Wise wrote: >> >> On 3/26/2018 9:44 AM, David Ahern wrote: >>> On 3/26/18 8:30 AM, Steve Wise wrote: >>>> On 3/26/2018 9:17 AM, David Ahern wrote: >>>>> On 2/27/18 9:07 AM, Steve Wise wrote: >>>>>> diff --git a/rdma/rdma.h b/rdma/rdma.h >>>>>> index 5809f70..e55205b 100644 >>>>>> --- a/rdma/rdma.h >>>>>> +++ b/rdma/rdma.h >>>>>> @@ -18,10 +18,12 @@ >>>>>> #include <libmnl/libmnl.h> >>>>>> #include <rdma/rdma_netlink.h> >>>>>> #include <time.h> >>>>>> +#include <net/if_arp.h> >>>>>> >>>>>> #include "list.h" >>>>>> #include "utils.h" >>>>>> #include "json_writer.h" >>>>>> +#include <rdma/rdma_cma.h> >>>>>> >>>>> did you forget to add rdma_cma.h? I don't see that file in my repo. >>>> It is provided by the rdma-core package, upon which rdma tool now >>>> depends for the rdma_port_space enum. >>>> >>> You need to add a check for the package, and only build rdma if that >>> package is installed. See check_mnl in configure for an example. >> Ok, that makes sense. > IMHO, better solution will be to copy those files to iproute2. Hey Leon, Why is it better in your opinion? My gut tells me adding rdma_cma.h to iproute2 means more uabi type syncing. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html