> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Friday, March 23, 2018 11:44 AM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Leon Romanovsky <leon@xxxxxxxxxx>; Doug Ledford > <dledford@xxxxxxxxxx>; Leon Romanovsky <leonro@xxxxxxxxxxxx>; RDMA > mailing list <linux-rdma@xxxxxxxxxxxxxxx>; Daniel Jurgens > <danielj@xxxxxxxxxxxx>; Mark Bloch <markb@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next v1 07/13] IB/ocrdma: Removed GID add/del null > routines > > On Fri, Mar 23, 2018 at 03:31:45AM +0000, Parav Pandit wrote: > > Hi Jason, > > > > > From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > > > Sent: Tuesday, March 13, 2018 9:06 AM > > > To: Doug Ledford <dledford@xxxxxxxxxx>; Jason Gunthorpe > > > <jgg@xxxxxxxxxxxx> > > > Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>; RDMA mailing list <linux- > > > rdma@xxxxxxxxxxxxxxx>; Daniel Jurgens <danielj@xxxxxxxxxxxx>; Mark > > > Bloch <markb@xxxxxxxxxxxx>; Parav Pandit <parav@xxxxxxxxxxxx>; Leon > > > Romanovsky <leon@xxxxxxxxxx> > > > Subject: [PATCH rdma-next v1 07/13] IB/ocrdma: Removed GID add/del > > > null routines > > > > > > From: Parav Pandit <parav@xxxxxxxxxxxx> > > > > > > add_gid() and del_gid() are optional callback routines. > > > ib_core ignores invoking them while updating GID table entries if > > > they are not implemented by provider drivers. Therefore remove them. > > > > > > Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx> > > > Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx> > > > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > > > Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx> > > > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 -- > > > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 16 ---------------- > > > drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 10 ---------- > > > 3 files changed, 28 deletions(-) > > > > > [..] > > > > I realized lately that this breaks the ocrdma driver. > > ib_cache_update() looks at the add_gid(), del_gid() pointer > > initialization to figure out whether to build sw_cache or not using > > rdma_cap_roce_gid_table() API. So need to revert this patch. Sorry > > for the overlook. > > Oy, I missed that too.. > > Since we both missed it, and it is crazy to require drivers to have empty > functions, lets not go back to it? > > How about adding a flag someplace and not test for add_gid/del_gid? > Flag is not needed. ib_cache_update() needs fix anyway. So I will send that patch in short while today. > Whichever, please send a patch, quickly, let us no get to the merge window with > this unfixed.. > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
