Hi Jason, > -----Original Message----- > From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > Sent: Tuesday, March 13, 2018 9:06 AM > To: Doug Ledford <dledford@xxxxxxxxxx>; Jason Gunthorpe > <jgg@xxxxxxxxxxxx> > Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>; RDMA mailing list <linux- > rdma@xxxxxxxxxxxxxxx>; Daniel Jurgens <danielj@xxxxxxxxxxxx>; Mark Bloch > <markb@xxxxxxxxxxxx>; Parav Pandit <parav@xxxxxxxxxxxx>; Leon > Romanovsky <leon@xxxxxxxxxx> > Subject: [PATCH rdma-next v1 07/13] IB/ocrdma: Removed GID add/del null > routines > > From: Parav Pandit <parav@xxxxxxxxxxxx> > > add_gid() and del_gid() are optional callback routines. > ib_core ignores invoking them while updating GID table entries if they are not > implemented by provider drivers. Therefore remove them. > > Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx> > Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx> > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx> > --- > drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 -- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 16 ---------------- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 10 ---------- > 3 files changed, 28 deletions(-) > [..] I realized lately that this breaks the ocrdma driver. ib_cache_update() looks at the add_gid(), del_gid() pointer initialization to figure out whether to build sw_cache or not using rdma_cap_roce_gid_table() API. So need to revert this patch. Sorry for the overlook. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
