On 2018/3/20 1:51, Jason Gunthorpe wrote:
> On Mon, Mar 19, 2018 at 09:36:07PM +0800, Yixian Liu wrote:
>> The data in resp will be copied from kernel to userspace,
>> thus it needs to be intialized to zeros. This bug is reported
>> by dan carpenter. It is imported by following patch.
>>
>> Fixes: e088a685eae9 (hns: Support rq record doorbell for the user space)
>>
>> Signed-off-by: Yixian Liu <liuyixian@xxxxxxxxxx>
>> drivers/infiniband/hw/hns/hns_roce_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, to for-next, but I modified the commit message as Leon noted
> and added a Reported-by for Dan. Pease follow this pattern in future:
>
> commit df7e40425813c50cd252e6f5e348a81ef1acae56 (HEAD -> k.o/for-next)
> Author: Yixian Liu <liuyixian@xxxxxxxxxx>
> Date: Mon Mar 19 21:36:07 2018 +0800
>
> RDMA/hns: Fix init resp when alloc ucontext
>
> The data in resp will be copied from kernel to userspace, thus it needs to
> be initialized to zeros to avoid copying uninited stack memory.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Fixes: e088a685eae9 ("RDMA/hns: Support rq record doorbell for the user space")
> Signed-off-by: Yixian Liu <liuyixian@xxxxxxxxxx>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
>
> Thanks,
> Jason
>
Hi Jason,
Thanks a lot for your much clearer description! I will follow this pattern.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
