On 2018/3/19 22:01, Leon Romanovsky wrote:
> On Mon, Mar 19, 2018 at 09:36:07PM +0800, Yixian Liu wrote:
>> The data in resp will be copied from kernel to userspace,
>> thus it needs to be intialized to zeros. This bug is reported
>> by dan carpenter. It is imported by following patch.
>>
>> Fixes: e088a685eae9 (hns: Support rq record doorbell for the user space)
>>
>> Signed-off-by: Yixian Liu <liuyixian@xxxxxxxxxx>
>
> Hi,
>
> There are two small things:
> 1. Extra space line between fixes and Signed-off-by.
> 2. No " in fixes line.
>
> Add this line to you [alias] section of gitconfig
>
> fixes = log --abbrev=12 -1 --format='Fixes: %h (\"%s\")'
>
> and it will create canonical Fixes line for any supplied commit SHA.
>
> ➜ kernel git:(rdma-next) git fixes e088a685eae9
> Fixes: e088a685eae9 ("RDMA/hns: Support rq record doorbell for the user space")
>
> Thanks
>
Hi, Leon, thanks for your useful information!
>> ---
>> drivers/infiniband/hw/hns/hns_roce_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
>> index e1ee666..6e48b1f 100644
>> --- a/drivers/infiniband/hw/hns/hns_roce_main.c
>> +++ b/drivers/infiniband/hw/hns/hns_roce_main.c
>> @@ -338,7 +338,7 @@ static struct ib_ucontext *hns_roce_alloc_ucontext(struct ib_device *ib_dev,
>> {
>> int ret = 0;
>> struct hns_roce_ucontext *context;
>> - struct hns_roce_ib_alloc_ucontext_resp resp;
>> + struct hns_roce_ib_alloc_ucontext_resp resp = {};
>> struct hns_roce_dev *hr_dev = to_hr_dev(ib_dev);
>>
>> resp.qp_tab_size = hr_dev->caps.num_qps;
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
