On 15/03/2018 21:59, Steve Wise wrote: > > > On 3/15/2018 2:50 PM, Leon Romanovsky wrote: >> On Wed, Mar 14, 2018 at 06:21:09PM +0200, Leon Romanovsky wrote: >>> On Wed, Mar 14, 2018 at 11:03:32AM -0500, Steve Wise wrote: >>>>>>> Is something missing? >>>>>> The fix is waiting in wip/dl-for-next, it should merge over tomorrow. >>>>>> >>>>>> cherry-pick this to fix it: >>>>>> >>>>>> commit d83a69c2b1b17a8aedc7a75ba8b620bfd2057e93 >>>>>> Author: Saeed Mahameed <saeedm@xxxxxxxxxxxx> >>>>>> Date: Wed Mar 7 15:44:48 2018 -0800 >>>>>> >>>>>> net/mlx5: Use MLX5_IPSEC_DEV macro for ipsec caps >>>>>> >>>>>> Fix build break of mlx5_accel_ipsec_device_caps is not defined when >>>>>> MLX5_ACCEL is not selected, use MLX5_IPSEC_DEV instead which handles >>>>>> such case. >>>>>> >>>>>> Signed-off-by: Saeed Mahameed <saeedm@xxxxxxxxxxxx> >>>>>> Reported-by: Doug Ledford <dledford@xxxxxxxxxx> >>>>>> >>>>>> Jason >>>> It also seems mlx5 is broken somehow. With the above, it compiles, but I >>>> don't get any netdev interface added when I load mlx5_ib: >>>> >>>> [54975.990560] mlx5_0:wait_for_async_commands:736:(pid 6035): done with all >>>> pending requests >>>> [54978.041338] mlx5_1:wait_for_async_commands:736:(pid 6035): done with all >>>> pending requests >>>> [54983.996241] mlx5_core 0000:83:00.0: firmware version: 12.21.2010 >>>> [54984.909826] mlx5_core 0000:83:00.0: Port module event: module 0, Cable >>>> plugged >>>> [54984.918074] mlx5_core 0000:83:00.1: firmware version: 12.21.2010 >>>> [54985.831329] mlx5_core 0000:83:00.1: Port module event: module 1, Cable >>>> unplugged >>>> [54985.900659] mlx5_ib: Mellanox Connect-IB Infiniband driver v5.0-0 >>>> [54985.907456] mlx5_ib: Mellanox Connect-IB Infiniband driver v5.0-0 >>>> >>>> The same setup works with 4.14.25: >>>> >>>> [root@stevo1 ~]# dmesg|grep mlx5 >>>> [ 5.787809] mlx5_core 0000:83:00.0: firmware version: 12.21.2010 >>>> [ 6.684023] mlx5_core 0000:83:00.0: Port module event: module 0, Cable >>>> plugged >>>> [ 6.689769] mlx5_core 0000:83:00.1: firmware version: 12.21.2010 >>>> [ 7.593204] mlx5_core 0000:83:00.1: Port module event: module 1, Cable >>>> unplugged >>>> [ 7.606499] mlx5_core 0000:83:00.0: MLX5E: StrdRq(0) RqSz(1024) StrdSz(1) >>>> RxCqeCmprss(0) >>>> [ 7.769859] mlx5_core 0000:83:00.1: MLX5E: StrdRq(0) RqSz(1024) StrdSz(1) >>>> RxCqeCmprss(0) >>>> [ 7.962760] mlx5_core 0000:83:00.0 enp131s0f0: renamed from eth0 >>>> [ 7.975142] mlx5_core 0000:83:00.1 enp131s0f1: renamed from eth1 >>>> [ 16.573759] mlx5_ib: Mellanox Connect-IB Infiniband driver v5.0-0 >>>> [ 105.460515] mlx5_core 0000:83:00.0 enp131s0f0: Link up >>>> [root@stevo1 ~]# >>>> >>>> >>>> Leon, any ideas? >>> No, I didn't heard any complains from our verification team, but maybe >>> Saeed is aware of any known issues. >> Steve, >> >> Can you send me you config? I'll try it on Sunday. >> >> It worked for me, >> > > Attached. Thanks! It seems MLX5_CORE_EN isn't set, which of course explains why you don't see any net devices. Mark -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html