On Wed, Mar 14, 2018 at 11:45:07AM +0200, Leon Romanovsky wrote: > On Tue, Mar 13, 2018 at 04:26:46PM -0600, Jason Gunthorpe wrote: > > MLX4_USER_DEV_CAP_LARGE_CQE (via mlx4_ib_alloc_ucontext_resp.dev_caps) > > and MLX4_IB_QUERY_DEV_RESP_MASK_CORE_CLOCK_OFFSET (via > > mlx4_uverbs_ex_query_device_resp.comp_mask) are copied directly to > > userspace and form part of the uAPI. > > > > Move them to the uapi header where they belong. > > > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > > drivers/infiniband/hw/mlx4/main.c | 2 +- > > drivers/infiniband/hw/mlx4/mlx4_ib.h | 4 ---- > > drivers/net/ethernet/mellanox/mlx4/fw.c | 1 + > > drivers/net/ethernet/mellanox/mlx4/main.c | 1 + > > The fact that you mixed our "ethernet" part with "uapi/rdma/mlx4-abi.h" > doesn't look good and we would like to avoid it. Well putting RDMA core ABI stuff into the ethernet driver in the first place was a strange idea. This is just fixing that to be done properly. You keep saying you don't want to to change mlx4 in any major way, so lets just leave this patch as is, unless someone has a simple idea to get rid of userspace_caps.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
