On Tue, Mar 13, 2018 at 04:26:46PM -0600, Jason Gunthorpe wrote: > MLX4_USER_DEV_CAP_LARGE_CQE (via mlx4_ib_alloc_ucontext_resp.dev_caps) > and MLX4_IB_QUERY_DEV_RESP_MASK_CORE_CLOCK_OFFSET (via > mlx4_uverbs_ex_query_device_resp.comp_mask) are copied directly to > userspace and form part of the uAPI. > > Move them to the uapi header where they belong. > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > --- > drivers/infiniband/hw/mlx4/main.c | 2 +- > drivers/infiniband/hw/mlx4/mlx4_ib.h | 4 ---- > drivers/net/ethernet/mellanox/mlx4/fw.c | 1 + > drivers/net/ethernet/mellanox/mlx4/main.c | 1 + The fact that you mixed our "ethernet" part with "uapi/rdma/mlx4-abi.h" doesn't look good and we would like to avoid it. Thanks
Attachment:
signature.asc
Description: PGP signature
