On Mon, Mar 12, 2018 at 10:37 PM, Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote: > On Mon, Mar 12, 2018 at 08:22:59PM +0000, Ruhl, Michael J wrote: >> Just a side comment. >> >> From the amount of code going into uverbs_std_types.c for this >> new feature it seems like this file is going to get very large quickly. >> >> Would it be reasonable to split new objects (and/or any new >> updates for the standard objects) into new files (uverbs_std_types_flows.c or >> something similar). If so, this seems like this would be the opportune >> feature to start doing this. > > Agree. > > In rdma-core I already started things out this way, let us copy that > into the kernel.. > > Basically one .c file per object.. > > Matan do you agree? > Yeah, I agree. I'll move flow_action into it's own file. > Jason Matan > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html