Re: [PATCH rdma-rc] IB/core: Fix possible crash to access NULL netdev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-03-07 at 08:07 +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav@xxxxxxxxxxxx>
> 
> resolved_dev returned might be NULL as ifindex is transient number.
> Ignoring NULL check of resolved_dev might crash the kernel.
> Therefore perform NULL check before accessing resolved_dev.
> 
> Additionally rdma_resolve_ip_route() invokes addr_resolve() which
> performs check and address translation for loopback ifindex.
> Therefore, checking it again in rdma_resolve_ip_route() is not helpful.
> Therefore, the code is simplified to avoid IFF_LOOPBACK check.
> 
> Fixes: 200298326b27 ("IB/core: Validate route when we init ah")
> Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx>
> Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx>
> ---

Thanks, applied to for-rc.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux