Re: [PATCH v2 rdma-next 7/9] RDMA/nldev: provide detailed MR information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 19, 2018 at 05:17:29PM -0600, Steve Wise wrote:

> > Wondering if keys should not be disclosed for security?
> > 
> > > +	RDMA_NLDEV_ATTR_RES_IOVA,		/* u64 */
> > 
> > What is this supposed to be ?
> > 
> 
> It is the address or 64b value used in ib_sge.addr field of SGEs.  mr.iova
> defines the beginning address of the MR.

But kernel MRs can be fragmented, and we will have fragmented user MRs
soon too I think.

> > We are talking about some MRs now with very complicated layouts, and
> > support those in the kernel too.
> > 
> > We already can't leak a kernel pointer here.. Not sure we should even
> > talk about pointers here at all..
> 
> It is part of what an application provides to register a MR.  It will help
> in debugging an application to verify that the MR registered has the correct
> iova. 

Still, worried about security, exposing pointers is frowned on these
days.

Certainly no for any kernel MR.

> > > +	RDMA_NLDEV_ATTR_RES_MRLEN,		/* u64 */
> > > +	RDMA_NLDEV_ATTR_RES_PGSIZE,		/* u32 */
> > 
> > Why pgsize?
> 
> Why dump it?  Because the page size of a MR isn't necessarily the host page
> size.  

But the page size can be variable inside a MR, seems like a weird
thing to report.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux