> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Monday, February 19, 2018 5:03 PM > To: Steve Wise > Cc: dledford@xxxxxxxxxx; leon@xxxxxxxxxx; yishaih@xxxxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 rdma-next 7/9] RDMA/nldev: provide detailed MR > information > > On Mon, Feb 19, 2018 at 08:22:11AM -0800, Steve Wise wrote: > > > + RDMA_NLDEV_ATTR_RES_MR, /* nested table */ > > + RDMA_NLDEV_ATTR_RES_MR_ENTRY, /* nested table */ > > + RDMA_NLDEV_ATTR_RES_RKEY, /* u32 */ > > + RDMA_NLDEV_ATTR_RES_LKEY, /* u32 */ > > What about stag? It's the same thing, really. And the API to rdma applications uses rkey/lkey, not stag. > > Wondering if keys should not be disclosed for security? > > > + RDMA_NLDEV_ATTR_RES_IOVA, /* u64 */ > > What is this supposed to be ? > It is the address or 64b value used in ib_sge.addr field of SGEs. mr.iova defines the beginning address of the MR. > We are talking about some MRs now with very complicated layouts, and > support those in the kernel too. > > We already can't leak a kernel pointer here.. Not sure we should even > talk about pointers here at all.. It is part of what an application provides to register a MR. It will help in debugging an application to verify that the MR registered has the correct iova. > > > + RDMA_NLDEV_ATTR_RES_MRLEN, /* u64 */ > > + RDMA_NLDEV_ATTR_RES_PGSIZE, /* u32 */ > > Why pgsize? Why dump it? Because the page size of a MR isn't necessarily the host page size. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
