Re: [PATCH rdma-rc 01/15] IB/ipoib: Do not warn if IPoIB debugfs doesn't exist

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 13, 2018 at 11:06:02AM -0500, Dennis Dalessandro wrote:
> On 2/13/2018 5:18 AM, Leon Romanovsky wrote:
> >   	struct ipoib_dev_priv *priv = ipoib_priv(dev);
> > -	WARN_ONCE(!priv->mcg_dentry, "null mcg debug file\n");
> > -	WARN_ONCE(!priv->path_dentry, "null path debug file\n");
> >   	debugfs_remove(priv->mcg_dentry);
> >   	debugfs_remove(priv->path_dentry);
> >   	priv->mcg_dentry = priv->path_dentry = NULL;
> >
>
> Do we really want to keep sending stuff like this for RC? I get that it's a
> trivial patch and all, but it's not actually fixing anything. Just a console
> spam that only happens once.

It is more than simple console spam, but actual crash on the system with
warning == panic.

Thanks

>
> -Denny

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux