On Tue, Feb 13, 2018 at 12:00:25PM -0500, Dennis Dalessandro wrote:
> On 2/13/2018 5:18 AM, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >
> > Resource tracking of XRCD objects is not implemented in current
> > version of restrack and hence can be removed.
> >
> > Fixes: 02d8883f520e ("RDMA/restrack: Add general infrastructure to track RDMA resources")
> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > ---
> > drivers/infiniband/core/restrack.c | 5 -----
> > include/rdma/restrack.h | 4 ----
> > 2 files changed, 9 deletions(-)
> >
> > diff --git a/drivers/infiniband/core/restrack.c b/drivers/infiniband/core/restrack.c
> > index 857637bf46da..d8dc709a3715 100644
> > --- a/drivers/infiniband/core/restrack.c
> > +++ b/drivers/infiniband/core/restrack.c
> > @@ -63,7 +63,6 @@ static struct ib_device *res_to_dev(struct rdma_restrack_entry *res)
> > {
> > enum rdma_restrack_type type = res->type;
> > struct ib_device *dev;
> > - struct ib_xrcd *xrcd;
> > struct ib_pd *pd;
> > struct ib_cq *cq;
> > struct ib_qp *qp;
> > @@ -81,10 +80,6 @@ static struct ib_device *res_to_dev(struct rdma_restrack_entry *res)
> > qp = container_of(res, struct ib_qp, res);
> > dev = qp->device;
> > break;
> > - case RDMA_RESTRACK_XRCD:
> > - xrcd = container_of(res, struct ib_xrcd, res);
> > - dev = xrcd->device;
> > - break;
> > default:
> > WARN_ONCE(true, "Wrong resource tracking type %u\n", type);
> > return NULL;
> > diff --git a/include/rdma/restrack.h b/include/rdma/restrack.h
> > index c2d81167c858..2cdf8dcf4bdc 100644
> > --- a/include/rdma/restrack.h
> > +++ b/include/rdma/restrack.h
> > @@ -28,10 +28,6 @@ enum rdma_restrack_type {
> > * @RDMA_RESTRACK_QP: Queue pair (QP)
> > */
> > RDMA_RESTRACK_QP,
> > - /**
> > - * @RDMA_RESTRACK_XRCD: XRC domain (XRCD)
> > - */
> > - RDMA_RESTRACK_XRCD,
> > /**
> > * @RDMA_RESTRACK_MAX: Last entry, used for array dclarations
> > */
> >
>
> Not -rc material in my opinion.
We are in -rc1 and it is exactly the time to clean up the code which was
entered a couple of weeks before.
>
> -Denny
Attachment:
signature.asc
Description: PGP signature
