> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Friday, February 09, 2018 10:13 AM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Bart Van Assche <Bart.VanAssche@xxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx > Subject: Re: [PATCH rdma-core] mlx4: Fix 1<<31 expressions > > On Fri, Feb 09, 2018 at 04:12:24PM +0000, Parav Pandit wrote: > > > > I did a patch that will make our public headers mostly strictly > > > conforming to C11 with -Wpedantic set, which I've been wondering if it is > worth sending.. > > > Any reason to use open code instead of using BIT() macro from > > include/linux/bitops.h which does the same thing? > > BIT only works in the kernel. This is a publich header from rdma-core userspace. > o.k. Got it. Same duplicated definition exist in kernel too which is not yet fixed because its unused, I guess. Likely user space headers don't have any BIT() or support macros. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
