Re: [PATCH] RDMA/vmw_pvrdma: Use standard way to check return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-01-24 at 13:17 +0200, Yuval Shaia wrote:
> -	if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) == 0) {
> +	if (!pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {

Sorry but I absolutely don't like this change. I think testing a return value
using "== 0" is easier to read than using !.

Bart.��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux