> -----Original Message----- > From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] > Sent: Monday, January 15, 2018 4:48 PM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Leon Romanovsky <leon@xxxxxxxxxx>; Doug Ledford > <dledford@xxxxxxxxxx>; RDMA mailing list <linux-rdma@xxxxxxxxxxxxxxx>; > Daniel Jurgens <danielj@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next 1/3] RDMA/core: Remove RoCE support from > rdma_addr_get_sgid() > > On Mon, Jan 15, 2018 at 10:34:13PM +0000, Parav Pandit wrote: > > > > Can you define what the SGID/DGID should be in the rdma CM uapi when > > > working with rocee? > > > > > It is the GIDs derived from the IP address using ip2gid() conversion. > > So then why is it OK for this patch to start returning dev_addr->src_dev_addr ? > It is not ok for RoCE. Therefore as the subject line says, it is no longer supported for RoCE. For other transports the code is unchanged. It continues to report src_dev_addr. For example, for IB transport GIDs are not derived IP address. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
